Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VTS from the ingress controller #2643

Merged
merged 1 commit into from
Jun 15, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 14, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 14, 2018
@codecov-io
Copy link

Codecov Report

Merging #2643 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2643      +/-   ##
==========================================
- Coverage    40.8%   40.76%   -0.05%     
==========================================
  Files          74       74              
  Lines        5083     5076       -7     
==========================================
- Hits         2074     2069       -5     
+ Misses       2726     2725       -1     
+ Partials      283      282       -1
Impacted Files Coverage Δ
internal/ingress/controller/controller.go 2.22% <ø> (+0.01%) ⬆️
internal/ingress/annotations/annotations.go 80.64% <ø> (-0.31%) ⬇️
internal/ingress/controller/config/config.go 98.23% <ø> (-0.05%) ⬇️
internal/watch/file_watcher.go 80.76% <0%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c6201b...63b38e1. Read the comment docs.

@itskingori
Copy link
Member

@aledbf I was just looking into VTS metrics. Is there a reason why this is being removed?

@itskingori
Copy link
Member

@aledbf NVM, seen #2618.

@aledbf
Copy link
Member Author

aledbf commented Jun 14, 2018

@itskingori please check #2608 (comment)

@antoineco
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3cbd2d6 into kubernetes:master Jun 15, 2018
@aledbf aledbf deleted the remove-vts branch June 15, 2018 19:16
zevisert pushed a commit to zevisert/doku-mgmt that referenced this pull request Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants