Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in command #2641

Closed
wants to merge 1 commit into from
Closed

Fix typo in command #2641

wants to merge 1 commit into from

Conversation

allanchau
Copy link

What this PR does / why we need it:

Fixes the command for checking if ingress controller pods have started.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Fixes the command for checking if ingress controller pods have started.
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: allanchau
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: aledbf

Assign the PR to them by writing /assign @aledbf in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 14, 2018
@allanchau
Copy link
Author

/assign @aledbf

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 14, 2018
@codecov-io
Copy link

Codecov Report

Merging #2641 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2641   +/-   ##
=======================================
  Coverage   40.69%   40.69%           
=======================================
  Files          75       75           
  Lines        5123     5123           
=======================================
  Hits         2085     2085           
  Misses       2756     2756           
  Partials      282      282

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43cf56c...541ee0f. Read the comment docs.

@antoineco
Copy link
Contributor

@allanchau thanks!
Do you mind if I cherry-pick this into #2368?

@aledbf
Copy link
Member

aledbf commented Jun 14, 2018

@aledbf aledbf closed this Jun 14, 2018
@aledbf
Copy link
Member

aledbf commented Jun 14, 2018

 kubectl get pods --all-namespaces -l app=ingress-nginx --watch
NAMESPACE       NAME                                        READY     STATUS    RESTARTS   AGE
ingress-nginx   nginx-ingress-controller-58c9df5856-bzmk4   1/1       Running   0          1d

@allanchau
Copy link
Author

@aledbf I used helm to install ingress helm install stable/nginx-ingress and kubectl get pods --all-namespaces -l app=ingress-nginx --watch didn't seem to pick up anything.

@antoineco No problem, as long as you guys are happy with it 😄

@aledbf
Copy link
Member

aledbf commented Jun 14, 2018

@allanchau ok, the docs in this repository are for the code and deployment provided here.
The helm chart is not part of this project but developed by other part of the community.

Edit: maybe the chart could change the labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants