-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in command #2641
Fix typo in command #2641
Conversation
Fixes the command for checking if ingress controller pods have started.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: allanchau Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @aledbf |
Codecov Report
@@ Coverage Diff @@
## master #2641 +/- ##
=======================================
Coverage 40.69% 40.69%
=======================================
Files 75 75
Lines 5123 5123
=======================================
Hits 2085 2085
Misses 2756 2756
Partials 282 282 Continue to review full report at Codecov.
|
@allanchau thanks! |
Closing. This is correct. Please check https://github.com/kubernetes/ingress-nginx/blob/master/deploy/mandatory.yaml#L237 |
|
@aledbf I used helm to install ingress @antoineco No problem, as long as you guys are happy with it 😄 |
@allanchau ok, the docs in this repository are for the code and deployment provided here. Edit: maybe the chart could change the labels |
What this PR does / why we need it:
Fixes the command for checking if ingress controller pods have started.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: