Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait the result of the controller deployment before running any test #2638

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 13, 2018

What this PR does / why we need it:

Avoid running any test if the ingress controller deployment is not working. This will help to avoid timeouts with e2e tests in case of startup failures.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 13, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 13, 2018
Wait the result of the controller deployment before running any test
@codecov-io
Copy link

Codecov Report

Merging #2638 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2638      +/-   ##
==========================================
- Coverage   40.83%   40.69%   -0.14%     
==========================================
  Files          75       75              
  Lines        5123     5123              
==========================================
- Hits         2092     2085       -7     
- Misses       2750     2756       +6     
- Partials      281      282       +1
Impacted Files Coverage Δ
cmd/nginx/main.go 23.66% <0%> (-5.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5046129...f3c9bba. Read the comment docs.

@aledbf aledbf merged commit 764bcd5 into kubernetes:master Jun 13, 2018
@aledbf aledbf deleted the watch-rollout branch June 13, 2018 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants