Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for custom error pages #2630

Merged
merged 2 commits into from
Jun 12, 2018
Merged

Update documentation for custom error pages #2630

merged 2 commits into from
Jun 12, 2018

Conversation

antoineco
Copy link
Contributor

@antoineco antoineco commented Jun 12, 2018

Fixes #2613

@aledbf requires a new build of the custom-error-pages image.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 12, 2018
@codecov-io
Copy link

codecov-io commented Jun 12, 2018

Codecov Report

Merging #2630 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2630   +/-   ##
=======================================
  Coverage   40.74%   40.74%           
=======================================
  Files          75       75           
  Lines        5117     5117           
=======================================
  Hits         2085     2085           
  Misses       2753     2753           
  Partials      279      279

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 306910d...4cbe5a9. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Jun 12, 2018

@antoineco please remove the file nginx-custom-errors.yaml and refer to the deploy guide instead.

@aledbf aledbf self-assigned this Jun 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: antoineco
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: aledbf

Assign the PR to them by writing /assign @aledbf in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 12, 2018
@antoineco
Copy link
Contributor Author

/assign @aledbf

@aledbf
Copy link
Member

aledbf commented Jun 12, 2018

Merging. Change in docs and the image is not testes in CI

@aledbf aledbf merged commit 55679aa into kubernetes:master Jun 12, 2018
@aledbf
Copy link
Member

aledbf commented Jun 12, 2018

@antoineco thanks!

@aledbf
Copy link
Member

aledbf commented Jun 12, 2018

@antoineco images are already available.

fmejia97 pushed a commit to Shopify/ingress that referenced this pull request Jun 18, 2018
* Update documentation for custom error pages

* custom-error-pages: Fix path to error pages

Bump version to 0.2
@bwolfehcm
Copy link

Hi,
Can someone tell me how to add a custom error page to the ingress controller. The documentation isn't clear on how to do this. It seems that I have to build a custom image to replace the default-backend.

@antoineco
Copy link
Contributor Author

antoineco commented Apr 28, 2020

@bwolfehcm you may have more chances finding help on Slack than in an issue closed 2 years ago, but yes, that's correct, you have to build your own backend. This could be a webserver serving static assets, or the backend of your choice (a Go application in the example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: Using custom-error-pages for 5xx codes unclear
5 participants