Crossplat fixes #2602
Merged
Crossplat fixes #2602
+23
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign @aledbf |
|
@toolboc please squash the commits and we are ready to go |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, toolboc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #2602 +/- ##
=======================================
Coverage 40.68% 40.68%
=======================================
Files 75 75
Lines 5108 5108
=======================================
Hits 2078 2078
Misses 2751 2751
Partials 279 279Continue to review full report at Codecov.
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR contains changes to the nginx image that are required for proper cross-platform referencing of lua libraries.
Explanation:
This is a two-part PR to address issues in non x86-x64 builds with regard to lua library references that was uncovered during investigation of Issue #2547. This PR contains changes to the base nginx image which are required to merge in order to verify the CI build before a subsequent change to nginx.tmpl will occur in PR #2597 . Acceptance of this PR will require a republish of the nginx base image for all platforms to enable acceptance of #2597.
Which issue this PR fixes
Addresses #2547