Update nginx dependencies #2588
Conversation
k8s-ci-robot
added
approved
|
@toolboc we need that module installed in the base image independently of the lua waf module |
Codecov Report
@@ Coverage Diff @@
## master #2588 +/- ##
=======================================
Coverage 40.54% 40.54%
=======================================
Files 75 75
Lines 5105 5105
=======================================
Hits 2070 2070
Misses 2754 2754
Partials 281 281Continue to review full report at Codecov.
|
images/nginx/build.sh
Outdated
| luarocks install lrexlib-pcre 2.7.2-1 | ||
| fi | ||
|
|
||
| luarocks install lua-cjson |
There was a problem hiding this comment.
We already have cjson being installed at https://github.com/kubernetes/ingress-nginx/pull/2588/files#diff-bd50bd51e758b65562491458b5a6f46dR88.
There was a problem hiding this comment.
It's ok if I remove that and we use luarocks? For some reason that package is not being installed in arm
There was a problem hiding this comment.
oh interesting, yeah we can use luarocks instead, but could you fix version?
images/nginx/build.sh
Outdated
| fi | ||
|
|
||
| luarocks install lua-cjson | ||
| luarocks install luasocket |
There was a problem hiding this comment.
this should not be necessary for that PR, we already have ngx.socket we can use
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Add required module for #2586
Which issue this PR fixes: fixes #2547