-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add secret scheme details to the example #2583
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
@@ Coverage Diff @@
## master #2583 +/- ##
=======================================
Coverage 40.54% 40.54%
=======================================
Files 75 75
Lines 5105 5105
=======================================
Hits 2070 2070
Misses 2754 2754
Partials 281 281 Continue to review full report at Codecov.
|
I signed the CLA |
/lgtm |
@aviadatsnyk thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, aviadatsnyk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
I'm not sure if this is a docs fix or a bug report (but I think it's the former): if you create a basic-auth secret from a file not named
auth
(i.emyauth.htpasswd
) - the ingress controller returns a 503 (not writing anything to the error log, at least not on the default settings).Special notes for your reviewer:
If this is a bug and not a docs issue, or I missed the relevant docs - sorry.