-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add geoip2 module and DB to nginx build #2559
Conversation
@glennslaven please increase the TAG variable in the images/nginx/Makefile version |
@aledbf Should that tag match the tag in the root Makefile where it sets the |
No, only to the Makefile in the nginx directory. This is because the image is not built and publish by travis, is a manual process after we merge this PR. Then we can update the main Makefile |
@glennslaven please rebase |
527ee88
to
2fa5390
Compare
Codecov Report
@@ Coverage Diff @@
## master #2559 +/- ##
=======================================
Coverage 40.68% 40.68%
=======================================
Files 75 75
Lines 5108 5108
=======================================
Hits 2078 2078
Misses 2751 2751
Partials 279 279 Continue to review full report at Codecov.
|
/lgtm |
@glennslaven thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, glennslaven The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
MaxMind is deprecating their legacy databases, updates for them will no longer be available after 2019-01-02. See https://support.maxmind.com/geolite-legacy-discontinuation-notice/
This adds support for the GeoLite2 databases https://dev.maxmind.com/geoip/geoip2/geolite2/ via https://github.com/leev/ngx_http_geoip2_module.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #2550Special notes for your reviewer:
Adds the City & ASN GeoLite2 databases, subsequent PR will update the ingress controller and template