Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for grpc_set_header #2524

Merged
merged 1 commit into from
May 17, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented May 16, 2018

Which issue this PR fixes:

fixes #2493
fixes #2407

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 16, 2018
@aledbf aledbf force-pushed the set-grpc-headers branch 2 times, most recently from 22fc92e to 937c1b8 Compare May 16, 2018 20:24
@aledbf aledbf added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2018
@aledbf
Copy link
Member Author

aledbf commented May 16, 2018

adding tests :)

@aledbf aledbf force-pushed the set-grpc-headers branch from 937c1b8 to 37dae52 Compare May 16, 2018 22:30
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 16, 2018
@aledbf aledbf removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2018
@antoineco
Copy link
Contributor

Needs rebase on #2528.

@aledbf aledbf force-pushed the set-grpc-headers branch from 37dae52 to ff3e182 Compare May 17, 2018 12:35
@aledbf
Copy link
Member Author

aledbf commented May 17, 2018

Needs rebase

done

@codecov-io
Copy link

Codecov Report

Merging #2524 into master will increase coverage by 0.01%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2524      +/-   ##
==========================================
+ Coverage   40.73%   40.74%   +0.01%     
==========================================
  Files          73       73              
  Lines        5015     5021       +6     
==========================================
+ Hits         2043     2046       +3     
- Misses       2700     2701       +1     
- Partials      272      274       +2
Impacted Files Coverage Δ
internal/ingress/controller/controller.go 2.25% <ø> (ø) ⬆️
internal/ingress/controller/template/template.go 64.97% <37.5%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef8a0a...ff3e182. Read the comment docs.

@antoineco
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2baad5d into kubernetes:master May 17, 2018
@aledbf aledbf deleted the set-grpc-headers branch May 17, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support grpc_set_header auth-tls-pass-certificate-to-upstream does not work for GRPC
5 participants