Simplify installation and e2e manifests

[aledbf]

Also, use RBAC by default.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aledbf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aledbf]

This can be merged after we release 0.15

[aledbf]

ping @zrdaley @diazjf

[diazjf]

Hey @aledbf thanks for the PR, makes it a lot easier to follow. I just have a few thoughts.

[diazjf]

Add minikube addons disable addon-manager to this.

[diazjf]

Maybe we should just have everything enabled and then just edit the deployment?

[diazjf]

Currently we perform the following:

kubectl set image \
    deployments \
    --namespace ingress-nginx \
    --selector app=ingress-nginx \
    nginx-ingress-controller=${REGISTRY}/nginx-ingress-controller:${TAG}

but in the future minikube will already have this deployment in the kube-system namespace and once that happens we can just edit the deployment on the kube-system namespace instead of creating a new one.

[aledbf]

I don't want to assume minikube is only way to run tests

[diazjf]

Should we just use the kube-system namespace that minikube already provides.

[aledbf]

The idea is to use the manifest we provide to the users in this repository and also be able to run e2e tests in any kubernetes cluster

[diazjf]

Just curious, whats this for?

[aledbf]

The flag --publish-service is used to extract information about the Service fronting the ingress controllers. The controller will set the endpoint records on the ingress objects to reflect those on the service. If you don't use this flag the controller uses the IP address of the node

[aledbf]

@diazjf also, at some point a migration to prow.k8s.io could be requested and that do not runs minikube.

[diazjf]

@aledbf makes sense to me. The user shouldn't be forced to minikube for development and testing. I mean in the case where make dev-env which relies on minikube, that we should make sure that all we do is simply edit the existing deploy in the kube-system namespace.

[antoineco]

According to the YAML spec, this marks the beginning of a document, not the end.

[aledbf]

done

[codecov-io]

Codecov Report

Merging #2515 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2515   +/-   ##
=======================================
  Coverage   40.73%   40.73%           
=======================================
  Files          73       73           
  Lines        5015     5015           
=======================================
  Hits         2043     2043           
  Misses       2700     2700           
  Partials      272      272

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef8a0a...7b29a0c. Read the comment docs.