Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add annotation to enable rewrite logs in a location #2437

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Add annotation to enable rewrite logs in a location #2437

merged 1 commit into from
Apr 27, 2018

Conversation

JordanP
Copy link
Contributor

@JordanP JordanP commented Apr 27, 2018

Fixes #2426

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 27, 2018
@aledbf
Copy link
Member

aledbf commented Apr 27, 2018

@JordanP please run make code-generator and push the changes

@aledbf
Copy link
Member

aledbf commented Apr 27, 2018

Also please add e2e tests

@JordanP
Copy link
Contributor Author

JordanP commented Apr 27, 2018

I have not really tested this besides unit tests. It should be safe though. What would be the best way to functionally test this ? Should I build a docker image and run this on some local K8s ?

@JordanP
Copy link
Contributor Author

JordanP commented Apr 27, 2018

Ok I'll add some e2e tests

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2018
@JordanP
Copy link
Contributor Author

JordanP commented Apr 27, 2018

Boy I feel bad... Hope I am not spamming some inbox...

@JordanP
Copy link
Contributor Author

JordanP commented Apr 27, 2018

/assign @aledbf

@aledbf
Copy link
Member

aledbf commented Apr 27, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2018
@aledbf
Copy link
Member

aledbf commented Apr 27, 2018

@JordanP thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, JordanP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2018
@k8s-ci-robot k8s-ci-robot merged commit 0813b38 into kubernetes:master Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JordanP @aledbf @k8s-ci-robot