Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golint installation #2414

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Fix golint installation #2414

merged 1 commit into from
Apr 24, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 24, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 24, 2018
@antoineco
Copy link
Contributor

antoineco commented Apr 24, 2018

/lgtm
Let's revert it as soon as the issue is fixed upstream

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

Codecov Report

Merging #2414 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2414   +/-   ##
=======================================
  Coverage   40.91%   40.91%           
=======================================
  Files          74       74           
  Lines        5252     5252           
=======================================
  Hits         2149     2149           
  Misses       2809     2809           
  Partials      294      294

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9e1961...d424eed. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit 97d7119 into kubernetes:master Apr 24, 2018
@antoineco
Copy link
Contributor

Fixed upstream 🎉

@aledbf aledbf deleted the fix-golint branch April 24, 2018 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants