-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize documentation #2413
Reorganize documentation #2413
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@akx first, thank you for doing this. Documentation is by far the weakest point of ingress-nginx. Can you sign the CLA? |
@aledbf Just signed. :) |
@@ -0,0 +1,24 @@ | |||
#!/usr/bin/env python3 | |||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the header boilerplate like https://github.com/kubernetes/ingress-nginx/blob/master/hack/boilerplate/boilerplate.py
@@ -1,4 +1,4 @@ | |||
# Role Based Access Control - RBAC | |||
# Role Based Access Control (RBAC) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not linked properly (see live demo)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is, it's available in the menus. :)
Where did you find a broken link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got a 404 when clicking on the corresponding link in the side menu, probably a cached response then!
@akx please run |
Before this (awesome) PR gets merged, should we consider having that documentation hosted and automatically updated right away? @akx do you know if GitHub pages would be a good candidate? |
I think this is the only option if we want to keep this up to date. Edit: http://www.mkdocs.org/user-guide/deploying-your-docs/#github-pages |
Yup, you could have a new "Docs" Travis stage ;) |
@aledbf Boilerplate fixed. Apparently Yes, Github Pages should be absolutely fine :) After all, it's just a static site. |
Codecov Report
@@ Coverage Diff @@
## master #2413 +/- ##
==========================================
+ Coverage 40.92% 41.05% +0.12%
==========================================
Files 74 74
Lines 5248 5252 +4
==========================================
+ Hits 2148 2156 +8
+ Misses 2807 2803 -4
Partials 293 293
Continue to review full report at Codecov.
|
/approve |
@antoineco Rebased. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akx, aledbf, antoineco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR:
docs/
mkdocs-material
.Why we need it: As a devops person trying to configure
ingress-nginx
, I grew very frustrated about the seeming (dis)organization of the documentation. There were duplicate files, just random notes smattered into README.md, etc., which felt like a pain.With this PR merged, someone (likely someone more involved with the project core) could set up Read The Docs to automatically generate a searchable, navigable doc site like this:
Please let me know if there's anything you'd like changed about the PR, or if you have questions! 🙇