Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for controller getEndpoints #2401

Merged
merged 1 commit into from
Apr 22, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 22, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 22, 2018
@aledbf aledbf added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2018
@codecov-io
Copy link

codecov-io commented Apr 22, 2018

Codecov Report

Merging #2401 into master will increase coverage by 0.93%.
The diff coverage is 84.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2401      +/-   ##
==========================================
+ Coverage   39.78%   40.72%   +0.93%     
==========================================
  Files          73       74       +1     
  Lines        5225     5228       +3     
==========================================
+ Hits         2079     2129      +50     
+ Misses       2856     2807      -49     
- Partials      290      292       +2
Impacted Files Coverage Δ
internal/ingress/controller/controller.go 2.24% <0%> (+0.16%) ⬆️
internal/ingress/controller/endpoints.go 94.33% <94.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18a6a30...777c637. Read the comment docs.

@aledbf aledbf force-pushed the test-endpoints branch 7 times, most recently from aae05da to 894d90f Compare April 22, 2018 03:28
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 22, 2018
@aledbf aledbf force-pushed the test-endpoints branch 3 times, most recently from 952a3cc to aad6045 Compare April 22, 2018 03:59
@aledbf aledbf removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2018
@antoineco
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 62895ff into kubernetes:master Apr 22, 2018
@aledbf aledbf deleted the test-endpoints branch April 22, 2018 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants