Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the default cookie name in doc #2372

Merged
merged 1 commit into from
Apr 18, 2018

Conversation

rajatjindal
Copy link
Contributor

What this PR does / why we need it:

Fix the documentation and example for cookie based session-affinity

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 18, 2018
@rajatjindal
Copy link
Contributor Author

/assign @justinsb

@codecov-io
Copy link

Codecov Report

Merging #2372 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2372      +/-   ##
=========================================
- Coverage   39.12%   39.1%   -0.02%     
=========================================
  Files          73      73              
  Lines        5204    5204              
=========================================
- Hits         2036    2035       -1     
- Misses       2878    2880       +2     
+ Partials      290     289       -1
Impacted Files Coverage Δ
internal/watch/file_watcher.go 80.76% <0%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c37ed7e...4237f29. Read the comment docs.

@antoineco
Copy link
Contributor

antoineco commented Apr 18, 2018

/lgtm missing that superpower apparently

@k8s-ci-robot
Copy link
Contributor

@antoineco: changing LGTM is restricted to assignees, and only kubernetes org members may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aledbf
Copy link
Member

aledbf commented Apr 18, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2018
@aledbf
Copy link
Member

aledbf commented Apr 18, 2018

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, rajatjindal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 396a19b into kubernetes:master Apr 18, 2018
@aledbf
Copy link
Member

aledbf commented Apr 18, 2018

@rajatjindal thanks!

@rajatjindal
Copy link
Contributor Author

thanks to you guys for working on such awesome opensource tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants