Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape variables in add-base-url annotation #2344

Merged
merged 1 commit into from
Apr 13, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 13, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 13, 2018
@codecov-io
Copy link

Codecov Report

Merging #2344 into master will not change coverage.
The diff coverage is 63.63%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2344   +/-   ##
======================================
  Coverage    39.1%   39.1%           
======================================
  Files          73      73           
  Lines        5202    5202           
======================================
  Hits         2034    2034           
  Misses       2878    2878           
  Partials      290     290
Impacted Files Coverage Δ
internal/ingress/controller/template/template.go 65.52% <63.63%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fba5c0...82b6c33. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Apr 13, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

@aledbf: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aledbf aledbf added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 13, 2018
@nicksardo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, nicksardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 361e53f into kubernetes:master Apr 13, 2018
@aledbf
Copy link
Member Author

aledbf commented Apr 13, 2018

@nicksardo thanks!

@ghost
Copy link

ghost commented Apr 19, 2018

@aledbf Hi, may I ask will this fix get involved in the next release?

@aledbf
Copy link
Member Author

aledbf commented Apr 19, 2018

@zaumreit this is already included in 0.13.0

@aledbf aledbf deleted the xss-base-tag branch April 21, 2018 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants