Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in lua script #2337

Closed
wants to merge 1 commit into from
Closed

Fix typo in lua script #2337

wants to merge 1 commit into from

Conversation

xianlubird
Copy link
Contributor

Signed-off-by: xianlubird [email protected]

@xianlubird
Fix typo in lua script
718c238 
Signed-off-by: xianlubird <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xianlubird
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bprashanth

Assign the PR to them by writing /assign @bprashanth in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

antoineco
antoineco reviewed Apr 17, 2018
View reviewed changes
rootfs/etc/nginx/lua/balancer.lua
@@ -95,7 +95,7 @@ local function sync_backend(backend)
ngx.shared.balancer_ewma_last_touched_at:flush_all()
end

ngx.log(ngx.INFO, "syncronization completed for: " .. backend.name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible candidate for merging with #2358.

@aledbf
Copy link
Member

aledbf commented Apr 17, 2018

@xianlubird you need to run make code-generator to pass the validations

@antoineco antoineco mentioned this pull request Apr 17, 2018
Merged
3 tasks
@antoineco
Copy link
Contributor

Consolidated in referenced PR (ping @aledbf)

@aledbf
Copy link
Member

aledbf commented Apr 17, 2018

Closing.

@aledbf aledbf closed this Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoineco antoineco antoineco left review comments

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xianlubird @k8s-ci-robot @aledbf @antoineco