Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable http2 on HTTP port to allow gRPC #2313

Closed
wants to merge 1 commit into from

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 8, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2018
@aledbf aledbf closed this Apr 8, 2018
@aledbf aledbf deleted the http2 branch April 12, 2018 02:40
@brandoncole
Copy link

@aledbf - This is exactly what I need :) Out of curiosity, why was it closed?

@aledbf
Copy link
Member Author

aledbf commented Apr 22, 2018

@brandoncole because this break http traffic

@verwilst
Copy link

Why not support use-http2c for example? That way you can choose between http2 ( ssl ports ) and h2c (non-ssl ports).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants