-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make proxy_next_upstream_tries configurable #2232
Conversation
/assign @nicksardo |
@maxlaverse please rebase, run |
1c00197
to
e34664d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2232 +/- ##
=========================================
+ Coverage 36.97% 37% +0.02%
=========================================
Files 71 71
Lines 5001 5008 +7
=========================================
+ Hits 1849 1853 +4
- Misses 2869 2872 +3
Partials 283 283
Continue to review full report at Codecov.
|
/approve |
@maxlaverse thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, maxlaverse The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
On deployments running a large number of pods, it is not desired to have Nginx retry failed requests as many times as they are pods. This PR makes
proxy_next_upstream_tries
configurable on the Nginx Ingress level through a ConfigMap, and on the Ingress leve with annotations.