Add worker-cpu-affinity nginx option #2201
Conversation
worker_cpu_affinity is a common optimization method for improving nginx performance, adding this as a custom configuration. Also fix some format issues found during editing.
k8s-ci-robot
added
cncf-cla: yes
| @@ -492,6 +496,7 @@ func NewDefault() Configuration { | |||
| cfg := Configuration{ | |||
| AllowBackendServerHeader: false, | |||
| AccessLogPath: "/var/log/nginx/access.log", | |||
| WorkerCpuAffinity: "", | |||
There was a problem hiding this comment.
Use auto as default. This way you don't need a condition in the template
There was a problem hiding this comment.
I have thought about this. However the default nginx behavior is not bind process to any cpus. And if auto is the default, the condition is still needed if user don't want any binding
Codecov Report
@@ Coverage Diff @@
## master #2201 +/- ##
==========================================
+ Coverage 36.54% 36.56% +0.01%
==========================================
Files 70 70
Lines 4884 4885 +1
==========================================
+ Hits 1785 1786 +1
Misses 2822 2822
Partials 277 277
Continue to review full report at Codecov.
|
|
/approve |
|
@oilbeater thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, oilbeater The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
worker_cpu_affinity is a common optimization method for improving nginx performance, adding this as a custom configuration. Also fix some format issues found during editing.
What this PR does / why we need it:
worker_cpu_affinity is a common optimization method for improving nginx performance, adding this as a custom configuration. Also fix some format issues found during editing.