Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong json tag #2193

Merged
merged 1 commit into from
Mar 12, 2018
Merged

fix wrong json tag #2193

merged 1 commit into from
Mar 12, 2018

Conversation

oilbeater
Copy link
Contributor

What this PR does / why we need it:
json tags are case sensitive when encoding, change omitEmpty to omitempty

json tags are case sensitive when encode, change omitEmpty to omitempty
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 11, 2018
@codecov-io
Copy link

Codecov Report

Merging #2193 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2193      +/-   ##
=========================================
+ Coverage   36.54%   36.6%   +0.06%     
=========================================
  Files          70      70              
  Lines        4884    4884              
=========================================
+ Hits         1785    1788       +3     
+ Misses       2822    2820       -2     
+ Partials      277     276       -1
Impacted Files Coverage Δ
internal/ingress/annotations/authreq/main.go 54.79% <ø> (ø) ⬆️
internal/ingress/annotations/ipwhitelist/main.go 44.44% <ø> (ø) ⬆️
cmd/nginx/main.go 23.44% <0%> (+2.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36cce00...cdac2e3. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Mar 12, 2018

/approve

@aledbf
Copy link
Member

aledbf commented Mar 12, 2018

@oilbeater thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, oilbeater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2018
@aledbf aledbf merged commit ebcdfad into kubernetes:master Mar 12, 2018
@oilbeater oilbeater deleted the fix-json-tag branch March 17, 2018 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants