Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checker test for bad pid #2191

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Add checker test for bad pid #2191

merged 1 commit into from
Mar 9, 2018

Conversation

antoineco
Copy link
Contributor

What this PR does / why we need it:

The second "valid request" checker test makes little sense because the pid file is rewritten with the expected pid. I adapted it to ensure we also fail in case the process with the expected pid does not exist.

/assign @aledbf

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2018
@aledbf
Copy link
Member

aledbf commented Mar 9, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2018
@aledbf
Copy link
Member

aledbf commented Mar 9, 2018

@antoineco thanks!

@aledbf aledbf merged commit 4a49d67 into kubernetes:master Mar 9, 2018
@codecov-io
Copy link

Codecov Report

Merging #2191 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2191   +/-   ##
======================================
  Coverage    36.4%   36.4%           
======================================
  Files          69      69           
  Lines        4859    4859           
======================================
  Hits         1769    1769           
  Misses       2820    2820           
  Partials      270     270

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbbeffb...b551297. Read the comment docs.

@antoineco antoineco deleted the checker-pid-test branch April 12, 2018 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants