Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ProxyPassParams setting #2185

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Remove ProxyPassParams setting #2185

merged 1 commit into from
Mar 8, 2018

Conversation

antoineco
Copy link
Contributor

What this PR does / why we need it:

TLDR: ingress.kubernetes.io/proxy-pass-params --> 🚪

This annotation made sense when the project was still a generic implementation, but nginx itself doesn't support such parameter, so there is no reason to keep it around.

Since I pushed that extra annotation, I feel responsible for removing it now :)

/assign @aledbf

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 7, 2018
@codecov-io
Copy link

Codecov Report

Merging #2185 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2185      +/-   ##
==========================================
+ Coverage   36.45%   36.57%   +0.11%     
==========================================
  Files          69       69              
  Lines        4861     4856       -5     
==========================================
+ Hits         1772     1776       +4     
+ Misses       2819     2811       -8     
+ Partials      270      269       -1
Impacted Files Coverage Δ
internal/ingress/annotations/proxy/main.go 57.74% <100%> (-0.15%) ⬇️
cmd/nginx/main.go 26.2% <0%> (+4.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a3a63...aad8676. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Mar 8, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2018
@aledbf aledbf merged commit 5ba0f4e into kubernetes:master Mar 8, 2018
@antoineco antoineco deleted the rm-proxypass-params branch March 8, 2018 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants