-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow referencing TLS secret from other namespace #2177
Allow referencing TLS secret from other namespace #2177
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aku105 Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #2177 +/- ##
=========================================
+ Coverage 36.45% 36.5% +0.04%
=========================================
Files 69 69
Lines 4861 4871 +10
=========================================
+ Hits 1772 1778 +6
- Misses 2819 2823 +4
Partials 270 270
Continue to review full report at Codecov.
|
CLA Signed. |
/assign @caseydavenport |
When TLS secret referred to when creating an ingress is of pattern <namespace>/<secretName> ingress controller will check the namespace specified rather than ingress' namespace. Fixes #2170
Closing. This must be allowed in the Ingress spec. We are not breaking this rule. |
Why we can't do this within annotations? |
I think there should be a way to access secrets in other namespaces if granted permission. |
What this PR does / why we need it: Allow referencing TLS secret from other namespaces. When TLS secret referred to when creating an ingress is of pattern
<namespace>/<secretName>
, ingress controller will check the namespace specified rather than ingress' namespace for secret.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #2170Special notes for your reviewer: NA