Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert deletion of dependency version override #2127

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Revert deletion of dependency version override #2127

merged 1 commit into from
Feb 21, 2018

Conversation

antoineco
Copy link
Contributor

What this PR does / why we need it:

The version override on the "github.com/docker/distribution" package is necessary in order to avoid the following build error:

# k8s.io/ingress-nginx/vendor/k8s.io/kubernetes/pkg/util/parsers
vendor/k8s.io/kubernetes/pkg/util/parsers/parsers.go:36:16: undefined: reference.ParseNormalizedNamed

This partially reverts commit 9bcb5b0.

Gopkg.lock is up-to-date.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 21, 2018
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 21, 2018
@aledbf
Copy link
Member

aledbf commented Feb 21, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2018
@aledbf
Copy link
Member

aledbf commented Feb 21, 2018

@antoineco thanks!

@codecov-io
Copy link

Codecov Report

Merging #2127 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2127   +/-   ##
=======================================
  Coverage   36.59%   36.59%           
=======================================
  Files          68       68           
  Lines        4837     4837           
=======================================
  Hits         1770     1770           
  Misses       2799     2799           
  Partials      268      268

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809aab7...ea42482. Read the comment docs.

@aledbf aledbf merged commit e9a9ce9 into kubernetes:master Feb 21, 2018
@antoineco antoineco deleted the dep branch February 21, 2018 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants