Refactor default backend handling and add better events #21
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
| @@ -694,7 +694,7 @@ func (l *L7) UpdateUrlMap(ingressRules utils.GCEURLMap) error { | |||
| } else { | |||
| l.um.DefaultService = l.glbcDefaultBackend.SelfLink | |||
| } | |||
| glog.V(3).Infof("Updating url map %+v", ingressRules) | |||
| glog.Infof("Updating url map:\n%+v", ingressRules) | |||
There was a problem hiding this comment.
The default level is 0 right?
| if err != nil { | ||
| return nil, err | ||
| } | ||
| glog.Warningf("Creating l7 without a default backend") |
There was a problem hiding this comment.
I noticed this before when I played with Ingress. Will this incur a lag for the default backend?
There was a problem hiding this comment.
we were always creating it as part of sync: https://github.com/kubernetes/contrib/blob/master/ingress/controllers/gce/loadbalancers/loadbalancers.go#L180, so this was just a redundant check. But we were also deleting it as part of sync, when there are no more lbs: https://github.com/kubernetes/contrib/blob/master/ingress/controllers/gce/loadbalancers/loadbalancers.go#L191
That's not the right time to try and delete it, because a url-map could still be referencing it (the delete would fail saying: "backend already in use", then we'd requeue, come back in, delete the url map, and now the backend delete would pass).
So I moved the delete to GC(), which happens after url map deletion.
https://github.com/kubernetes/ingress/pull/21/files#diff-247e0d4a5e00d30d32c0e454986614cdR210
|
LGTM |
|
I do not have permission to merge or apply label. |
|
Oh ,thanks |
bprashanth
added
the
lgtm
* deadlock detected * Add debug and fix duped UID * clean comments
* deadlock detected * Add debug and fix duped UID * clean comments
We were setting up and tearing down the default http backend used in url maps that don't have a user specified default backend in weird places that didn't make sense. This pr also sends better events that include health check information, and sets better timeouts on readiness-probes converted to health checks.