-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for enabling ssl_ciphers per host #2006
Conversation
Example ingress resource: → cat /tmp/test.yaml
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
name: test-ing
annotations:
nginx.ingress.kubernetes.io/proxy-buffering: "on"
# nginx.ingress.kubernetes.io/ssl-ciphers: "ALL:!aNULL:!EXPORT56:RC4+RSA:+HIGH:+MEDIUM:+LOW:+SSLv2:+EXP"
# nginx.ingress.kubernetes.io/client-body-buffer-size: 1k
spec:
tls:
- hosts:
- test.net
rules:
- host: test.net
http:
paths:
- path: /tea
backend:
serviceName: tea-svc
servicePort: 80
- host: test2.net
http:
paths:
- path: /tea
backend:
serviceName: tea-svc
servicePort: 80
---
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
name: test-ing2
annotations:
nginx.ingress.kubernetes.io/ssl-ciphers: "ALL:!aNULL:!EXPORT56:RC4+RSA:+HIGH:+MEDIUM:+LOW:+SSLv2:+EXP"
# nginx.ingress.kubernetes.io/client-body-buffer-size: 1k
spec:
tls:
- hosts:
- test.net
rules:
- host: test3.net
http:
paths:
- path: /tea-test
backend:
serviceName: tea-svc
servicePort: 80 Server sections from nginx config generated:
|
Another sample ingress resource used for testing: apiVersion: extensions/v1beta1
kind: Ingress
metadata:
name: test-ing
annotations:
nginx.ingress.kubernetes.io/ssl-ciphers: "ALL:!aNULL:!EXPORT56:RC4+RSA:+HIGH:+MEDIUM:+LOW:+SSLv2:+EXP"
# nginx.ingress.kubernetes.io/client-body-buffer-size: 1k
spec:
tls:
- hosts:
- test.net
rules:
- host: test.net
http:
paths:
- path: /tea
backend:
serviceName: tea-svc
servicePort: 80
- host: test2.net
http:
paths:
- path: /tea
backend:
serviceName: tea-svc
servicePort: 80
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, aramase The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@aramase thanks! |
This doesnt seem to work for the parameter I specified:
But the ingress is still only doing TLSv1.2 and none of the rest, any ideas? |
This PR adds annotation option to configure ssl_ciphers. Using the annotation will set the ssl_ciphers at the server level and will apply to all paths on the host.
(http://nginx.org/en/docs/http/ngx_http_ssl_module.html#ssl_ciphers)
fixes #1956