Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom port in redirects #1907

Merged
merged 1 commit into from
Jan 17, 2018
Merged

Fix custom port in redirects #1907

merged 1 commit into from
Jan 17, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 16, 2018

Which issue this PR fixes:

fixes #1882

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 16, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 36.64% when pulling 14f3110 on aledbf:fix-redirect-port into a1afc41 on kubernetes:master.

@aledbf aledbf merged commit b0e0712 into kubernetes:master Jan 17, 2018
@aledbf aledbf deleted the fix-redirect-port branch January 17, 2018 17:23
aledbf added a commit to aledbf/ingress-nginx that referenced this pull request Jan 18, 2018
@aledbf
Fix custom port in redirects (kubernetes#1907)
741ee53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redirect to https does not replace the http port correctly when specifying use-port-in-redirects in configmap
4 participants
@aledbf @k8s-ci-robot @k8s-reviewable @coveralls