Fix publish-service patch and update README #1867
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
deploy/patch-deployment.yaml
is a JSON patch that replaces the args created bydeploy/with-rbac.yaml
ordeploy/without-rbac.yaml
. This means the args have to be updated 3 times if anything changes.This is changes the patch to actually do an
add
operation for the providers that require the--publish-service
argument (e.g. https://github.com/kubernetes/ingress-nginx/tree/master/deploy#aws). It also formats the JSON to be a bit more readable instead of a single line.