Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish-service patch and update README #1867

Merged
merged 1 commit into from
Dec 31, 2017

Conversation

victortrac
Copy link
Contributor

What this PR does / why we need it: deploy/patch-deployment.yaml is a JSON patch that replaces the args created by deploy/with-rbac.yaml or deploy/without-rbac.yaml. This means the args have to be updated 3 times if anything changes.

This is changes the patch to actually do an add operation for the providers that require the --publish-service argument (e.g. https://github.com/kubernetes/ingress-nginx/tree/master/deploy#aws). It also formats the JSON to be a bit more readable instead of a single line.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 29, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 29, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 36.764% when pulling 918da87 on victortrac:master into cabd7cb on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 36.764% when pulling 918da87 on victortrac:master into cabd7cb on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Dec 31, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 31, 2017
@aledbf
Copy link
Member

aledbf commented Dec 31, 2017

@victortrac thanks!

@aledbf aledbf merged commit 2b24494 into kubernetes:master Dec 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants