Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth-tls-pass-certificate-to-upstream should be bool #1782

Merged
merged 1 commit into from
Dec 1, 2017

Conversation

morganwu277
Copy link
Contributor

auth-tls-pass-certificate-to-upstream annotation from the doc is confused as string, it should be bool value.

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 1, 2017
@aledbf
Copy link
Member

aledbf commented Dec 1, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2017
@aledbf
Copy link
Member

aledbf commented Dec 1, 2017

@morganwu277 thanks!

@aledbf aledbf merged commit 99d3e9e into kubernetes:master Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants