-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modsecurity module #1498
Add modsecurity module #1498
Conversation
06170ca
to
3f19664
Compare
Coverage remained the same at 33.582% when pulling 3f19664f10c7ecb0b3aaaadd3ef09406a63c9be8 on aledbf:nginx-modsecurity3 into c873ef6 on kubernetes:master. |
3f19664
to
b44fe56
Compare
Coverage decreased (-0.04%) to 33.544% when pulling b44fe5605d4c349f3dcdddded44ba0f74d18fc03 on aledbf:nginx-modsecurity3 into c873ef6 on kubernetes:master. |
Coverage remained the same at 33.582% when pulling b44fe5605d4c349f3dcdddded44ba0f74d18fc03 on aledbf:nginx-modsecurity3 into c873ef6 on kubernetes:master. |
b44fe56
to
0447484
Compare
Coverage remained the same at 33.492% when pulling 0447484db4dbcc9d87dc28fce05ea88555c64d95 on aledbf:nginx-modsecurity3 into 63155ee on kubernetes:master. |
0447484
to
a03d6eb
Compare
Coverage remained the same at 33.492% when pulling a03d6ebbb74efe836f5a52a6456ce9a992c57c65 on aledbf:nginx-modsecurity3 into 63155ee on kubernetes:master. |
a03d6eb
to
2d23c51
Compare
Coverage remained the same at 33.492% when pulling 2d23c5120bd7b689a597f0697da160647550510c on aledbf:nginx-modsecurity3 into 63155ee on kubernetes:master. |
2d23c51
to
a9a22b0
Compare
images/nginx-slim/build.sh
Outdated
--add-module=$BUILD_PATH/nginx-opentracing-$NGINX_OPENTRACING" | ||
|
||
if [[ ${ARCH} == "x86_64" ]]; then | ||
WITH_MODULES+=" --add-module=$BUILD_PATH/ModSecurity-nginx-$MODSECURITY" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aledbf I would only like to ask if that's possible for us to use --add-dynamic-module instead of --add-module, so NGINX creates a .so file, that could be loaded in runtime, allowing us to load this module only if the user want's this :)
Here are some examples, this is supported in NGINX community since version 1.9.11 and may use an absolute path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@nicksardo please merge and publish. Thanks! |
What this PR does / why we need it:
This PR adds the ModSecurity-nginx module to the nginx-slim image.