Introduce an upstream-hash-by annotation to support consistent hashing by nginx variable or text

[methodmissing]

This PR consolidates the changesets from 2 distinct fork PRs:

• Introduce an upstream-hash-by annotation to support consistent hashing by nginx variable Shopify/ingress#5
• Fix regressions from the initial pass of the upstream-hash-by annotation Shopify/ingress#6

Generates the following:

host:test user$ kubectl describe ing -n something-staging
Name:            something-web
Namespace:        something-staging
Address:        X.X.X.X
Default backend:    default-http-backend:80 (Y.Y.Y.Y:8080)
TLS:
  star-something terminates something-staging.something.com
Rules:
  Host                    Path    Backends
  ----                    ----    --------
  something-staging.something.com    
                             something-web:80 (<none>)
Annotations:
  auth-realm:        blah bblah
  auth-secret:        something-basic-auth
  auth-type:        basic
  upstream-hash-by:    $request_uri <<<<<<<<<<<<<<<<<<<<<<<<<<<

upstream something-staging-something-web-80 {
        # Load balance algorithm; empty for round robin, which is the default
        least_conn;

        hash $request_uri consistent; <<<<<<<<<<<<<<<<<<<<
        server Y.Y.Y.Y:8000 max_fails=0 fail_timeout=0;
}

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-reviewable]

This change is 

[coveralls]

Coverage increased (+0.01%) to 43.783% when pulling b6569af37dfaef5147e46c860193daf7e968d010 on methodmissing:upstream-hash-by into ab3afe5 on kubernetes:master.

[coveralls]

Coverage increased (+0.04%) to 33.505% when pulling f3d56e38299eaabac51364d7ed526a3d1004e679 on methodmissing:upstream-hash-by into 7ffa0ae on kubernetes:master.

[coveralls]

Coverage decreased (-0.0005%) to 33.467% when pulling f3d56e38299eaabac51364d7ed526a3d1004e679 on methodmissing:upstream-hash-by into 7ffa0ae on kubernetes:master.

[coveralls]

Coverage increased (+0.1%) to 33.582% when pulling d607cf6 on methodmissing:upstream-hash-by into 7ffa0ae on kubernetes:master.

[aledbf]

/lgtm

[aledbf]

@methodmissing thanks!