Chart: Add controller.service.external.labels & controller.service.internal.labels.

[samuelarogbonlo]

Add support for internal service specific labels
Fixes #12428

Description
This PR adds the ability to specify labels specifically for the internal ingress-nginx service without affecting the main controller service. This is particularly useful for use cases like external-dns configuration where labels need to be set only on the internal service.

Changes

• Modified templates/controller-service-internal.yaml to support internal-specific labels
• Removed mandatory annotations requirement for internal service
• Fixed indentation in templates/controller-deployment.yaml
• Added test case for internal service labels

Code Changes

1. Added support for internal-specific labels:

 labels:
    {{- include "ingress-nginx.labels" . | nindent 4 }}
    app.kubernetes.io/component: controller
  {{- if .Values.controller.service.internal.labels }}
    {{- toYaml .Values.controller.service.internal.labels | nindent 4 }}
  {{- end }}

2. Removed mandatory annotations requirement:

From

{{- if and .Values.controller.service.enabled .Values.controller.service.internal.enabled .Values.controller.service.internal.annotations -}}

To

{{- if and .Values.controller.service.enabled .Values.controller.service.internal.enabled -}}

Testing Performed
Tested the following scenarios:

1. Adding custom labels to internal service only
2. Verifying label isolation (labels on internal service don't appear on main service)
3. Creating internal service without requiring annotations
4. Confirming template renders correctly

Test configuration added in:
charts/ingress-nginx/ci/controller-service-internal-labels-values.yaml

Usage Example

controller:
  service:
    internal:
      enabled: true
      labels:
        external-dns.alpha.kubernetes.io/hostname: internal.example.com
        custom-label: test-value

Backward Compatibility
This change maintains backward compatibility by:

• Not changing behavior for existing configurations
• Only removing restrictions (required annotations)
• Preserving all existing label inheritance where appropriate
• Not requiring configuration of internal labels

Checklist

• [ ✅ ] Code follows repository style and conventions
• [ ✅ ] Templates render correctly
• [ ✅ ] Added test configuration
• [ ✅ ] Maintains backward compatibility
• [ ✅ ] Verified label isolation works as expected

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: samuelarogbonlo
Once this PR has been reviewed and has the lgtm label, please assign gacko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @samuelarogbonlo!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @samuelarogbonlo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	5ce79c0
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/678a8bf65ff0fa0008ab92bf

[Gacko]

/hold

[Gacko]

Looks better! Thank you! Please also consider adding unit tests in the tests/ directory.

[Gacko]

/retitle Chart: Add controller.service.external.labels & controller.service.internal.labels.
/triage accepted
/kind feature
/priority backlog
/hold

[Gacko]

Oh, and please update the README.md by running helm-docs.

[samuelarogbonlo]

Oh, and please update the README.md by running helm-docs.

Done