NGINX: Add NJS.

[anurag-rajawat]

What this PR does / why we need it:

This PR is the continuation of #11248.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

I verified my changes by:

• Deploying the ingress controller by following official doc
• Using the image built with these changes.

Here is a screenshots that show it has nginx-njs module:

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

Welcome @anurag-rajawat!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @anurag-rajawat. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	d318f27
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/675eb3397fce8b0008f5441b

[strongjz]

Great start. Can you add an e2e test that exercises using the njs model?

[strongjz]

Great start. Can you add an e2e test that exercises using the njs model?

This may have to wait till we release a new nignx base image. We do rebuild the controller in all e2e but not the nginx base.

[strongjz]

/ok-to-test

[strongjz]

/kind feature
/priority backlog

[strongjz]

We do build the nginx image, so we can add some e2e test for njs.
https://github.com/kubernetes/ingress-nginx/actions/runs/11776116543/job/32797881046#step:9:1

[Gacko]

I'm not even sure if we should still add this on Ingress NGINX. @strongjz

/hold

[anurag-rajawat]

Hey @strongjz, should we proceed with further changes?

[strongjz]

Hey @strongjz, should we proceed with further changes?

Let's chat after our maintainers talk tomorrow. We've got plans for things going forward.

[strongjz]

Also need to rebase to get the go lint ci 0207d18

[Gacko]

NGINX build is working again. We're now releasing v1.12 and then coming back here.

[longwuyuan]

This is a duplicate of https://github.com/kubernetes/ingress-nginx/pull/12447/files so need to close this

[Gacko]

No, it isn't. The other PR is newer and based on this PR.

[longwuyuan]

Can we track the change proposed in the other one instead of this one ?

[Gacko]

No, I'd like to keep this one as it's really only introducing NJS and this should complete the tests on its own.

[longwuyuan]

ok, then that implies a comment on the other one to remove the duplicacy

[Gacko]

The other one needs to be based on this here so it can already be tested. The moment we merge this one, @elizabeth-dev will rebase their PR.

[longwuyuan]

The other one needs to be based on this here so it can already be tested. The moment we merge this one, @elizabeth-dev will rebase their PR.

👍 left a note there

[elizabeth-dev]

yes, my PR(s) already start from this PR's branch, so it'll be an easy rebase when this is merged

[rikatz]

/lgtm

Let's gooo! :)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anurag-rajawat, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rikatz]

/hold cancel

[Gacko]

/cherry-pick main

[k8s-infra-cherrypick-robot]

@Gacko: I cannot cherry-pick the present PR on top of its base branch (main).

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.