-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images: Trigger NGINX build. #12076
Images: Trigger NGINX build. #12076
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gacko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/triage accepted |
/cherry-pick release-1.10 |
@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Gacko: new pull request created: #12077 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This triggers a build of the NGINX base image from the
release-1.11
branch as the state ofmain
currently differs from those on therelease-1.xx
branches. We therefore need a NGINX base image build we can use inrelease-1.xx
branches.Code-wise the NGINX base image on
release-1.11
does not differ fromrelease-1.10
. So it's safe to also use the resulting image onrelease-1.10
even though this might be a bit intransparent.