-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart: Add global.image.registry
.
#12028
Conversation
✅ Deploy Preview for kubernetes-ingress-nginx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/triage accepted |
/hold |
/unhold |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gacko, ubergesundheit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds a
global.image.registry
field to the chart which makes it possible to define the registry used for pulling images across the chart in a single place.This is useful for setups where Ingress NGINX is not getting installed as standalone but included in a different chart.
The fact that we are using the
global
key here makes this even easier as you only need to define it once for all the charts your including and so can reuse existing values instead of needing to change it for the Ingress NGINX chart.Types of changes
How Has This Been Tested?
Added unit tests.
Checklist: