Chart: Add controller.progressDeadlineSeconds.

[TrondT]

Add option to set progressDeadlineSeconds on Deployment: progressDeadlineSeconds

What this PR does / why we need it:

Some users would like to detect a failing deployment quicker than the default 600 seconds.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Tested with helm template with and without progressDeadlineSeconds set

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: TrondT / name: Trond (9461d29)

[k8s-ci-robot]

Welcome @TrondT!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @TrondT. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx ready!

Name	Link
🔨 Latest commit	9461d29
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/66f673467a82050008f1cf86
😎 Deploy Preview	https://deploy-preview-12017--kubernetes-ingress-nginx.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Gacko]

/triage accepted
/kind feature
/priority backlog
/hold

Hello and thank you for your contribution! Some notes: Please...

• ... set a non-nil default value.
• ... also implement this for the DaemonSet.
• ... implement Helm Unit Tests for the both the Deployment and the DaemonSet.
• ... use helm-docs for generating the README.md.
• ... do not change the go.sum.

Thank you in advance!

[TrondT]

Thanks for your quick response.
Will update accordingly.

[TrondT]

Regarding your comments, I have some thoughts to consider:
... set a non-nil default value.
By using 'nil' we will assume the kubernets default, as described here: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/#deployment-v1-apps
I believe a good practice is to not redefine if there are no need for such.
... also implement this for the DaemonSet.
DaemonSet spec does not include progressDeadlineSeconds, ref: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/#daemonset-v1-apps
... implement Helm Unit Tests for the both the Deployment and the DaemonSet.
Implemented test for Deployment.
... use helm-docs for generating the README.md.
Done.
... do not change the go.sum.
Reverted.

[TrondT]

I'll be happy to set default value for progressDeadlineSeconds to 600 if you thing that is a better solution...
Just let me know.

[Gacko]

Can you try 0 as default?

[Gacko]

I think we had a misunderstanding here: Using 0 in conjunction with an if would only render it if the value is not 0. So if someone does not change the default of 0, this field would never get rendered. But if you change it to, let's say, 30, then it gets rendered as expected.

[TrondT]

Now using 0 as default, so with this input:

spec:
  progressDeadlineSeconds: 0

the Deployment is rendered as follows:

spec:
  progressDeadlineSeconds: 600

Also tested in our cluster.

[Gacko]

/unhold
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, TrondT

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS [Gacko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment