NGINX: Remove inline Lua from template.

[rikatz]

What this PR does / why we need it:

We need to simplify our lifes and the nginx.conf file. This PR is the beginning of the work to remove any lua inline script from nginx template, calling the lua script directly.

The end goal is to remove any by_lua_block directive, even if this means we add more lua scripts temporarily

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	aa5c3ec
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/66ddc92ab3da2600082f6aba

[Gacko]

Do you want to merge this to main or the NGINX crossplane branch?

[rikatz]

@Gacko to main :)

[Gacko]

Then please wait until after the release. 😅

[rikatz]

Then please wait until after the release. 😅

I'm not on a rush :P

[Gacko]

/lgtm

[Gacko]

/unhold

[Gacko]

@rikatz I rebased your branch. Unhold whenever ready. :)

[rikatz]

/hold

I will still finish the other migrations! :D Will let you know once it is ready

[tao12345666333]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, rikatz, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Gacko,rikatz,tao12345666333]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Gacko]

Suggested change

	if: |
	(needs.changes.outputs.lua == 'true') || ${{ github.event.workflow_dispatch.run_e2e == 'true' }}
	if: fromJSON(needs.changes.outputs.lua) || fromJSON(github.event.workflow_dispatch.run_e2e)

Have you tried this?

[rikatz]

never tried. but then wouldn't it be better to change all of the ifs for this approach on a follow up PR?

[Gacko]

Suggested change

	balancer.balance()
	balancer.balance()

[Gacko]

Can we have the newline at EOF added in snippets?

[rikatz]

sorry I am not following. What would be the goal of adding a new line here?

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[k8s-ci-robot]

@rikatz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-ingress-nginx-lualint	b65dae6b80609c53e1255ffafec0d86032a601a4	link	true	/test pull-ingress-nginx-lualint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[rikatz]

/hold cancel