-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics: Remove ingress_upstream_latency_seconds
.
#11795
Conversation
Hi @chengjoey. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey! Thanks for your contribution, you're having a streak today, right? 😉 We can of course remove this metric if it's causing trouble, but sadly not in an upcoming patch release. I'd postpone this to v1.12. @strongjz WDYT? |
ingress_upstream_latency_seconds
metricingress_upstream_latency_seconds
.
1ca70be
to
fa84d5a
Compare
/triage accepted |
/assign |
/ok-to-test |
/lgtm |
Signed-off-by: joey <[email protected]>
/lgtm |
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chengjoey, Gacko, strongjz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
fix nginx controller oom due to
ingress_upstream_latency_seconds
metricingress_upstream_latency_seconds
will cause nginx pod oom, and this metric has been deprecated, so we can delete thisTypes of changes
Which issue/s this PR fixes
#10141
How Has This Been Tested?
Checklist: