Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Build: Add missing config, remove unused ones. #11774

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Cloud Build: Add missing config, remove unused ones. #11774

merged 1 commit into from
Aug 12, 2024

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Aug 12, 2024

/triage accepted
/kind bug
/priority backlog

GitHub is a bit confusing about the actual change. I removed the cloudbuild.yaml from ext-auth-example-authsvc and go-grpc-greeter-server and added one for e2e-test-echo.

There's now Prow job for the former but one for the latter.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 12, 2024
Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit ef0c7ce
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/66ba5b18a5b00100088599ab

@Gacko
Copy link
Member Author

Gacko commented Aug 12, 2024

/cherry-pick release-1.10

@Gacko
Copy link
Member Author

Gacko commented Aug 12, 2024

/cherry-pick release-1.11

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Gacko
Copy link
Member Author

Gacko commented Aug 12, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2024
@Gacko
Copy link
Member Author

Gacko commented Aug 12, 2024

https://github.com/kubernetes/ingress-nginx/blob/main/.github/workflows/images.yaml#L37

This should be fine. It's only GitHub.

https://github.com/kubernetes/ingress-nginx/blob/main/docs/examples/customization/external-auth-headers/auth-service.yaml#L21

I have no idea how this has ever been built. There is no image pushing config in the test infra.

@Gacko
Copy link
Member Author

Gacko commented Aug 12, 2024

Yep, also the image referenced here doesn't even exist (anymore):

Error response from daemon: failed to resolve reference "gcr.io/k8s-staging-ingress-nginx/ext-auth-example-authsvc:v1.0.0": gcr.io/k8s-staging-ingress-nginx/ext-auth-example-authsvc:v1.0.0: not found

Not nice, but also doesn't keep me from removing the useless cloudbuild.yaml.

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2024
@Gacko Gacko merged commit 28d2e78 into kubernetes:main Aug 12, 2024
23 of 24 checks passed
@Gacko Gacko deleted the systt branch August 12, 2024 19:37
@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: new pull request created: #11776

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: new pull request created: #11777

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants