-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud Build: Add missing config, remove unused ones. #11774
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gacko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
/cherry-pick release-1.10 |
/cherry-pick release-1.11 |
@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/hold |
https://github.com/kubernetes/ingress-nginx/blob/main/.github/workflows/images.yaml#L37 This should be fine. It's only GitHub. I have no idea how this has ever been built. There is no image pushing config in the test infra. |
Yep, also the image referenced here doesn't even exist (anymore):
Not nice, but also doesn't keep me from removing the useless /unhold |
@Gacko: new pull request created: #11776 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Gacko: new pull request created: #11777 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/triage accepted
/kind bug
/priority backlog
GitHub is a bit confusing about the actual change. I removed the
cloudbuild.yaml
fromext-auth-example-authsvc
andgo-grpc-greeter-server
and added one fore2e-test-echo
.There's now Prow job for the former but one for the latter.