Chart: Remove isControllerTagValid.

[Gacko]

What this PR does / why we need it:

This PR removes the isControllerTagValid template from the chart. According to its description, it should prevent users from installing old controller image versions, but this would require us to bump it with releases. Since nobody cared about it for a long time, I'd rather remove it and give users the possibility to define whatever image they want - even non-semver compliant ones.

Keep in mind: With the current implementation you could easily use v0.28.0 without that template complaining. I don't think this is adding any value and only takes users the possibility of using custom tags.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

Fixes #11708.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	54575a0
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/66aa5485961cb800084c8305

[Gacko]

/triage accepted
/kind bug
/priority backlog
/cc @strongjz @rikatz @cpanato @tamalsaha

[ubergesundheit]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, ubergesundheit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS [Gacko,ubergesundheit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Gacko]

/cherry-pick release-1.10

[Gacko]

/cherry-pick release-1.11

[k8s-infra-cherrypick-robot]

@Gacko: #11710 failed to apply on top of branch "release-1.10":

Applying: Chart: Remove `isControllerTagValid`.
Using index info to reconstruct a base tree...
M	charts/ingress-nginx/templates/_helpers.tpl
M	charts/ingress-nginx/templates/controller-daemonset.yaml
M	charts/ingress-nginx/templates/controller-deployment.yaml
M	charts/ingress-nginx/tests/controller-daemonset_test.yaml
M	charts/ingress-nginx/tests/controller-deployment_test.yaml
Falling back to patching base and 3-way merge...
Auto-merging charts/ingress-nginx/tests/controller-deployment_test.yaml
CONFLICT (content): Merge conflict in charts/ingress-nginx/tests/controller-deployment_test.yaml
Auto-merging charts/ingress-nginx/tests/controller-daemonset_test.yaml
CONFLICT (content): Merge conflict in charts/ingress-nginx/tests/controller-daemonset_test.yaml
Auto-merging charts/ingress-nginx/templates/controller-deployment.yaml
Auto-merging charts/ingress-nginx/templates/controller-daemonset.yaml
Auto-merging charts/ingress-nginx/templates/_helpers.tpl
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Chart: Remove `isControllerTagValid`.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@Gacko: #11710 failed to apply on top of branch "release-1.11":

Applying: Chart: Remove `isControllerTagValid`.
Using index info to reconstruct a base tree...
M	charts/ingress-nginx/templates/_helpers.tpl
M	charts/ingress-nginx/tests/controller-daemonset_test.yaml
M	charts/ingress-nginx/tests/controller-deployment_test.yaml
Falling back to patching base and 3-way merge...
Auto-merging charts/ingress-nginx/tests/controller-deployment_test.yaml
CONFLICT (content): Merge conflict in charts/ingress-nginx/tests/controller-deployment_test.yaml
Auto-merging charts/ingress-nginx/tests/controller-daemonset_test.yaml
CONFLICT (content): Merge conflict in charts/ingress-nginx/tests/controller-daemonset_test.yaml
Auto-merging charts/ingress-nginx/templates/_helpers.tpl
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Chart: Remove `isControllerTagValid`.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.