Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images: Bump OpenTelemetry C++ Contrib. #11629

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

dmehala
Copy link

@dmehala dmehala commented Jul 17, 2024

What this PR does / why we need it:

This PR bump the oTel module to e11348bb400d5472bf1da5d6128bead66fa111ff.

https://github.com/open-telemetry/opentelemetry-cpp-contrib/releases/tag/webserver%2Fv1.1.0

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Yes, manually.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 17, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @dmehala!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @dmehala. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2024
Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit d08027b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/66dd4f77a3517d00084fb1a2

@dmehala
Copy link
Author

dmehala commented Jul 27, 2024

/retest

@k8s-ci-robot
Copy link
Contributor

@dmehala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dmehala dmehala marked this pull request as ready for review July 27, 2024 10:51
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2024
@k8s-ci-robot k8s-ci-robot requested review from puerco and strongjz July 27, 2024 10:52
@longwuyuan
Copy link
Contributor

/assign @esigo

@dmehala
Copy link
Author

dmehala commented Aug 7, 2024

Gentle bump @esigo

1 similar comment
@dmehala
Copy link
Author

dmehala commented Aug 24, 2024

Gentle bump @esigo

Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the PR

@Gacko
Copy link
Member

Gacko commented Aug 24, 2024

/assign
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2024
@Gacko
Copy link
Member

Gacko commented Sep 4, 2024

Hey,

I just got some time to have a deeper look into your change.

I can totally understand that you'd like to have this particular commit in use in Ingress NGINX, because its your contribution and you made it for a reason.

Unfortunately we'd rather go for a real release than a commit on their main branch, even if this has not been the case in the past. I'd therefore try to implement their v1.1.0 release and also bump NGINX support to v1.25.5.

Of course this would not include your changes, but at least be a official release and align NGINX versions.

@strongjz
Copy link
Member

strongjz commented Sep 4, 2024

We've been burned in the on different components and using commits, not releases.

@dmehala
Copy link
Author

dmehala commented Sep 6, 2024

Hey @Gacko @strongjz ,
I completely understand, and that’s totally fair. I am wondering if you’re planning to integrate the new otel module (otel-webserver)?

Either way, I'm happy to help if you'd like :)

@Gacko Gacko force-pushed the dmehala/bump-otel branch from 87a6877 to 82cda5b Compare September 8, 2024 07:02
@Gacko Gacko changed the title Bump otel_ngx_module Images: Bump OpenTelemetry C++ Contrib. Sep 8, 2024
@Gacko Gacko force-pushed the dmehala/bump-otel branch from 82cda5b to d08027b Compare September 8, 2024 07:17
Copy link
Member

@Gacko Gacko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/triage accepted
/kind cleanup
/priority backlog
/lgtm

As stated before I replaced the commit to be used by the v1.1.0 tag.

Unfortunately and just from a first look there is a lot more to be done - but not now and not in this PR. Also this isn't because or up to you, @dmehala. So no worries please! I'll create a follow-up.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Sep 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmehala, esigo, Gacko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2024
@Gacko
Copy link
Member

Gacko commented Sep 8, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 8, 2024
@Gacko
Copy link
Member

Gacko commented Sep 8, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2024
@Gacko
Copy link
Member

Gacko commented Sep 8, 2024

/cherry-pick release-1.10

@Gacko
Copy link
Member

Gacko commented Sep 8, 2024

/cherry-pick release-1.11

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit ee61440 into kubernetes:main Sep 8, 2024
45 checks passed
@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: new pull request created: #11950

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: new pull request created: #11951

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bforchhammer
Copy link

bforchhammer commented Oct 1, 2024

I understand the intention to use only tagged releases, but I'm wondering if it makes sense at the moment, since there doesn't seem to be a release process for the opentelemetry-cpp-contrib/instrumentation/nginx module at all.

The releases visible for opentelemetry-cpp-contrib seem to be only for the instrumentation/otel-webserver-module library, which isn't used here as far as I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants