-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images: Bump OpenTelemetry C++ Contrib. #11629
Conversation
Welcome @dmehala! |
Hi @dmehala. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
/retest |
@dmehala: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @esigo |
Gentle bump @esigo |
1 similar comment
Gentle bump @esigo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR
/assign |
Hey, I just got some time to have a deeper look into your change. I can totally understand that you'd like to have this particular commit in use in Ingress NGINX, because its your contribution and you made it for a reason. Unfortunately we'd rather go for a real release than a commit on their main branch, even if this has not been the case in the past. I'd therefore try to implement their v1.1.0 release and also bump NGINX support to v1.25.5. Of course this would not include your changes, but at least be a official release and align NGINX versions. |
We've been burned in the on different components and using commits, not releases. |
87a6877
to
82cda5b
Compare
82cda5b
to
d08027b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/triage accepted
/kind cleanup
/priority backlog
/lgtm
As stated before I replaced the commit to be used by the v1.1.0 tag.
Unfortunately and just from a first look there is a lot more to be done - but not now and not in this PR. Also this isn't because or up to you, @dmehala. So no worries please! I'll create a follow-up.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmehala, esigo, Gacko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/unhold |
/cherry-pick release-1.10 |
/cherry-pick release-1.11 |
@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Gacko: new pull request created: #11950 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Gacko: new pull request created: #11951 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I understand the intention to use only tagged releases, but I'm wondering if it makes sense at the moment, since there doesn't seem to be a release process for the The releases visible for |
What this PR does / why we need it:
This PR bump the oTel module to
e11348bb400d5472bf1da5d6128bead66fa111ff
.https://github.com/open-telemetry/opentelemetry-cpp-contrib/releases/tag/webserver%2Fv1.1.0
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Yes, manually.
Checklist: