Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add information about HTTP/3 support. #11513

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

ipaqsa
Copy link
Contributor

@ipaqsa ipaqsa commented Jun 27, 2024

Update README to add information about HTTP/3 support status

Docs for #11470

What this PR does / why we need it:

It provides updates for README to describe HTTP/3 support status.

README describes the current status, the problem with OpenSSL and the next steps to add HTTP/3 support.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

Fixes #11502

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 27, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ipaqsa. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 27, 2024
Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit d577f52
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/66828526fe0177000821a29a

@Gacko
Copy link
Member

Gacko commented Jul 1, 2024

/triage accepted
/kind documentation
/priority backlog
/cc @longwuyuan
/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from Gacko July 1, 2024 08:48
@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jul 1, 2024
@k8s-ci-robot k8s-ci-robot requested a review from longwuyuan July 1, 2024 08:48
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 1, 2024
@Gacko
Copy link
Member

Gacko commented Jul 1, 2024

/cherry-pick release-1.10

@k8s-ci-robot k8s-ci-robot removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Jul 1, 2024
@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Gacko
Copy link
Member

Gacko commented Jul 1, 2024

/retitle Docs: Add information about HTTP/3 support.

@k8s-ci-robot k8s-ci-robot changed the title [docs] update README to add information about HTTP/3 support Docs: Add information about HTTP/3 support. Jul 1, 2024
images/nginx-1.25/README.md Outdated Show resolved Hide resolved
images/nginx-1.25/README.md Outdated Show resolved Hide resolved
images/nginx-1.25/README.md Outdated Show resolved Hide resolved
images/nginx-1.25/README.md Outdated Show resolved Hide resolved
images/nginx-1.25/README.md Show resolved Hide resolved
images/nginx-1.25/README.md Outdated Show resolved Hide resolved
images/nginx-1.25/README.md Outdated Show resolved Hide resolved
images/nginx-1.25/README.md Show resolved Hide resolved
images/nginx-1.25/README.md Outdated Show resolved Hide resolved
images/nginx-1.25/README.md Outdated Show resolved Hide resolved
@ipaqsa ipaqsa requested a review from Gacko July 1, 2024 09:19
images/nginx-1.25/README.md Outdated Show resolved Hide resolved
images/nginx-1.25/README.md Outdated Show resolved Hide resolved
@longwuyuan
Copy link
Contributor

Hopefully all HTTP3 PRs are linked.

Small nit - if/when comfortable, then please squash commits

Signed-off-by: Stepan Paksashvili <[email protected]>
@ipaqsa ipaqsa requested a review from Gacko July 1, 2024 10:30
@Gacko
Copy link
Member

Gacko commented Jul 1, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 1, 2024
@Gacko
Copy link
Member

Gacko commented Jul 1, 2024

The build job will probably fail, but this is not related to your PR.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, ipaqsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gacko Gacko merged commit 6a111a9 into kubernetes:main Jul 1, 2024
37 of 38 checks passed
@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: new pull request created: #11525

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A document is needed to explain that the current support for HTTP3 is not complete.
5 participants