Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chores: Align security contacts & chart maintainers to actual owners. #11465

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Chores: Align security contacts & chart maintainers to actual owners. #11465

merged 1 commit into from
Jun 17, 2024

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Jun 14, 2024

Aligns the assignees in the CVE report template, security contacts and maintainers in the chart to the people defined in the owner aliases of the repository (https://github.com/kubernetes/ingress-nginx/blob/main/OWNERS_ALIASES).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2024
@k8s-ci-robot k8s-ci-robot added area/helm Issues or PRs related to helm charts approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 14, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 14, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit f3a4e27
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/667018d781ed6f00089799f2

@Gacko
Copy link
Member Author

Gacko commented Jun 14, 2024

/cc @rikatz @cpanato

@k8s-ci-robot k8s-ci-robot requested review from cpanato and rikatz June 14, 2024 18:08
@Gacko
Copy link
Member Author

Gacko commented Jun 14, 2024

/triage accepted
/kind cleanup
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Jun 14, 2024
@Gacko
Copy link
Member Author

Gacko commented Jun 14, 2024

/cherry-pick release-1.10

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Gacko
Copy link
Member Author

Gacko commented Jun 14, 2024

/assign

@Gacko
Copy link
Member Author

Gacko commented Jun 17, 2024

/uncc @ubergesundheit

@k8s-ci-robot k8s-ci-robot removed the request for review from ubergesundheit June 17, 2024 08:04
tao12345666333
tao12345666333 requested changes Jun 17, 2024
View reviewed changes
charts/ingress-nginx/Chart.yaml Outdated Show resolved Hide resolved
tao12345666333
tao12345666333 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Gacko,tao12345666333]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e084ad0 into kubernetes:main Jun 17, 2024
18 checks passed
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 17, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: new pull request created: #11480

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Gacko Gacko deleted the xpgxj branch June 17, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubergesundheit ubergesundheit ubergesundheit left review comments

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@strongjz strongjz Awaiting requested review from strongjz

@cpanato cpanato Awaiting requested review from cpanato

@rikatz rikatz Awaiting requested review from rikatz

Assignees

@Gacko Gacko

@tao12345666333 tao12345666333

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gacko @k8s-infra-cherrypick-robot @k8s-ci-robot @ubergesundheit @tao12345666333