Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart: Remove controller.enableWorkerSerialReloads. #11400

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Chart: Remove controller.enableWorkerSerialReloads. #11400

merged 1 commit into from
Jun 3, 2024

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented May 31, 2024

What this PR does / why we need it:

This PR removes the recently in #10884 introduced value controller.enableWorkerSerialReloads from the chart.

There is no reason to explicitly name it in the ConfigMap. If one needs it, they can still look it up in the docs and add it manually via controller.config.

We can not support each and every ConfigMap entry via a separate value, especially if there's no extra logic around it and it's just being passed directly into the ConfigMap.

This change is non-breaking as it has not been released yet.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot requested a review from puerco May 31, 2024 11:57
@k8s-ci-robot k8s-ci-robot added the area/helm Issues or PRs related to helm charts label May 31, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 31, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2024
Copy link

netlify bot commented May 31, 2024

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 720fb94
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/6659bb0ab4c9d300080f7c67

@Gacko
Copy link
Member Author

Gacko commented May 31, 2024

/cc @cpanato @strongjz

@k8s-ci-robot k8s-ci-robot requested review from cpanato and strongjz May 31, 2024 12:40
@ubergesundheit
Copy link
Contributor

/lgtm

I agree that we probably don't need to have every possible value of the configmap in the helm values.

The deploy quick start guide mentions special configuration required for some cloud providers. Maybe it could be worth to mention the ability to change the configmap in a short paragraph there.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, ubergesundheit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 987039c into kubernetes:main Jun 3, 2024
18 checks passed
@Gacko Gacko deleted the usiqm branch June 3, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants