-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart: Remove controller.enableWorkerSerialReloads
.
#11400
Conversation
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
/lgtm I agree that we probably don't need to have every possible value of the configmap in the helm values. The deploy quick start guide mentions special configuration required for some cloud providers. Maybe it could be worth to mention the ability to change the configmap in a short paragraph there. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gacko, ubergesundheit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR removes the recently in #10884 introduced value
controller.enableWorkerSerialReloads
from the chart.There is no reason to explicitly name it in the ConfigMap. If one needs it, they can still look it up in the docs and add it manually via
controller.config
.We can not support each and every ConfigMap entry via a separate value, especially if there's no extra logic around it and it's just being passed directly into the ConfigMap.
This change is non-breaking as it has not been released yet.
Types of changes
Checklist: