-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt dashboards for Grafana 11 compatibility #11399
Adapt dashboards for Grafana 11 compatibility #11399
Conversation
Hi @Roberdvs. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
@Roberdvs thank you very much for this contribution. Much needed and hard to come by. Honestly speaking, can you comment on how would you yourself verify such a large change for accuracy. I am going to deploy on my kind/minikube cluster and browse through all available dashboards hopefully (and ideally). |
@Roberdvs once again thank you very much for this contribution. I tested and so glad that the big glaring compatibility error is gone. I also could not find any problem in any of the dashboard graphs. This is a very very welcome improvement. So good to see this. /ok-to-test |
/kind bug cc @strongjz @rikatz @tao12345666333 @cpanato @Gacko Please review/approve this |
/approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gacko, longwuyuan, Roberdvs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.10 |
@Gacko: new pull request created: #11414 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Grafana 11 turns off support for Angular plugins by default. This PR migrates affected panels to the corresponding modern versions.
I've tried to maintain the existing behavior, although there might be some minor changes in how some information is displayed.
NGINX Ingress controller
Before
After
Request Handling Performance
Before
After
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: