Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt dashboards for Grafana 11 compatibility #11399

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

Roberdvs
Copy link
Contributor

What this PR does / why we need it:

Grafana 11 turns off support for Angular plugins by default. This PR migrates affected panels to the corresponding modern versions.
image

I've tried to maintain the existing behavior, although there might be some minor changes in how some information is displayed.

NGINX Ingress controller

Before

image

After

image

Request Handling Performance

Before

image

After

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Roberdvs. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 31, 2024
Copy link

netlify bot commented May 31, 2024

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 7a16ba6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/6659b42e241b7300088c2768

@k8s-ci-robot k8s-ci-robot requested review from cpanato and Gacko May 31, 2024 11:28
@longwuyuan
Copy link
Contributor

@Roberdvs thank you very much for this contribution. Much needed and hard to come by.

Honestly speaking, can you comment on how would you yourself verify such a large change for accuracy. I am going to deploy on my kind/minikube cluster and browse through all available dashboards hopefully (and ideally).

@longwuyuan
Copy link
Contributor

@Roberdvs once again thank you very much for this contribution.

I tested and so glad that the big glaring compatibility error is gone. I also could not find any problem in any of the dashboard graphs. This is a very very welcome improvement. So good to see this.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2024
@longwuyuan
Copy link
Contributor

/kind bug
/triage accepted
/priority backlog
/lgtm

cc @strongjz @rikatz @tao12345666333 @cpanato @Gacko Please review/approve this

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 31, 2024
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels May 31, 2024
@Gacko
Copy link
Member

Gacko commented Jun 2, 2024

/approved

Copy link
Member

@Gacko Gacko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, longwuyuan, Roberdvs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit a02f5d2 into kubernetes:main Jun 2, 2024
7 checks passed
@Gacko
Copy link
Member

Gacko commented Jun 2, 2024

/cherry-pick release-1.10

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: new pull request created: #11414

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants