-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom annotations in the IngressClass template #11362
Add support for custom annotations in the IngressClass template #11362
Conversation
|
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Welcome @cparadal! |
Hi @cparadal. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
/ok-to-test |
/assign @ubergesundheit I see you are listed as |
176e2a6
to
3196074
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cparadal, ubergesundheit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds support for passing user-defined/custom annotations to the IngressClass resource template.
This is useful in scenarios where you need the IngressClass resource to contain a specific annotation, e.g
argocd.argoproj.io/sync-options: Prune=false
to prevent ArgoCD from pruning the ingress class on sync.Types of changes
Which issue/s this PR fixes
fixes #11359
How Has This Been Tested?
With helm template. Also ran unit tests and e2e tests, locally.
Checklist: