Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release chart 4.10.1 #11277

Merged
merged 2 commits into from
Apr 23, 2024
Merged

release chart 4.10.1 #11277

merged 2 commits into from
Apr 23, 2024

Conversation

strongjz
Copy link
Member

No description provided.

Signed-off-by: James Strong <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/helm Issues or PRs related to helm charts labels Apr 18, 2024
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 18, 2024
@strongjz
Copy link
Member Author

/hold

waiting on #11276 #11253

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
@Gacko
Copy link
Member

Gacko commented Apr 18, 2024

/lgtm

The failing tests are probably due to the image not being present in the registry, yet?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2024
@Gacko
Copy link
Member

Gacko commented Apr 18, 2024

/triage accepted
/kind feature
/priority important-soon
/cherry-pick main

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: once the present PR merges, I will cherry-pick it on top of main in a new PR and assign it to you.

In response to this:

/triage accepted
/kind feature
/priority important-soon
/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Apr 18, 2024
@strongjz
Copy link
Member Author

/lgtm

The failing tests are probably due to the image not being present in the registry, yet?

It's there in registry repo yaml but not in the registry for some reason

 Warning  Failed       12s (x3 over 52s)  kubelet            Failed to pull image "registry.k8s.io/ingress-nginx/controller:v1.10.1@sha256:e24f39d3eed6bcc239a56f20098878845f62baa34b9f2be2fd2c38ce9fb0f29e": rpc error: code = NotFound desc = failed to pull and unpack image "registry.k8s.io/ingress-nginx/controller@sha256:e24f39d3eed6bcc239a56f20098878845f62baa34b9f2be2fd2c38ce9fb0f29e": failed to resolve reference "registry.k8s.io/ingress-nginx/controller@sha256:e24f39d3eed6bcc239a56f20098878845f62baa34b9f2be2fd2c38ce9fb0f29e": registry.k8s.io/ingress-nginx/controller@sha256:e24f39d3eed6bcc239a56f20098878845f62baa34b9f2be2fd2c38ce9fb0f29e: not found

docker pull registry.k8s.io/ingress-nginx/controller:v1.10.1
Error response from daemon: manifest for registry.k8s.io/ingress-nginx/controller:v1.10.1 not found: manifest unknown: Failed to fetch "v1.10.1"

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2024
@Gacko
Copy link
Member

Gacko commented Apr 23, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@strongjz
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2024
@strongjz strongjz merged commit 5ed8402 into kubernetes:release-1.10 Apr 23, 2024
13 of 14 checks passed
@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: #11277 failed to apply on top of branch "main":

Applying: release chart 4.10.1
Using index info to reconstruct a base tree...
M	charts/ingress-nginx/Chart.yaml
M	charts/ingress-nginx/README.md
M	charts/ingress-nginx/values.yaml
Falling back to patching base and 3-way merge...
Auto-merging charts/ingress-nginx/values.yaml
Auto-merging charts/ingress-nginx/README.md
Auto-merging charts/ingress-nginx/Chart.yaml
CONFLICT (content): Merge conflict in charts/ingress-nginx/Chart.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 release chart 4.10.1
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/triage accepted
/kind feature
/priority important-soon
/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

strongjz added a commit to strongjz/ingress-nginx that referenced this pull request Apr 24, 2024
strongjz added a commit to strongjz/ingress-nginx that referenced this pull request Apr 24, 2024
strongjz added a commit to strongjz/ingress-nginx that referenced this pull request Apr 25, 2024
k8s-ci-robot pushed a commit that referenced this pull request Apr 25, 2024
k8s-infra-cherrypick-robot pushed a commit to k8s-infra-cherrypick-robot/ingress-nginx that referenced this pull request Jun 3, 2024
k8s-ci-robot pushed a commit that referenced this pull request Jun 3, 2024
release chart 4.10.1

Co-authored-by: James Strong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants