-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart: Reorder default backend HPA metrics. #11215
Chart: Reorder default backend HPA metrics. #11215
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @jozefhalgas! |
Hi @jozefhalgas. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
/retitle Chart: Reorder default backend HPA metrics. |
/cherry-pick release-1.10 Thanks a lot for your contribution! |
@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gacko, jozefhalgas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Gacko: new pull request created: #11217 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Order of metrics in default backend HPA resource is causing sync problems in ArgoCD. It is the same issue as describted here #10038 for controller HPA. The fix is a cosmetic change to the hpa template.
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
We've deployed this to our environments and ArgoCD sync was successful..
Checklist: