Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Owners: Promote Gacko to ingress-nginx-maintainers & ingress-nginx-reviewers. #11203

Merged
merged 6 commits into from
Apr 4, 2024
Merged

Owners: Promote Gacko to ingress-nginx-maintainers & ingress-nginx-reviewers. #11203

merged 6 commits into from
Apr 4, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link
Contributor

This is an automated cherry-pick of #11165

/assign Gacko

Gacko added 6 commits April 4, 2024 15:01
@Gacko
Owners: Sort ingress-nginx-maintainers & ingress-nginx-reviewers.
4c24dee
@Gacko
Owners: Update URL in aliases.
e380c5f
@Gacko
Images: Remove owners as it's identical to global owners.
b44f3d2
@Gacko
Images: Remove global owners from kube-webhook-certgen owners.
4ab8ee0
@Gacko
Owners: Remove members from aliases covered by other aliases.
9835f4a 
ingress-nginx-helm-maintainers:
- cpanato: Covered by ingress-nginx-maintainers
- strongjz: Covered by ingress-nginx-maintainers

ingress-nginx-helm-reviewers:
- cpanato: Covered by ingress-nginx-reviewers
- strongjz: Covered by ingress-nginx-reviewers

ingress-nginx-docs-maintainers:
- tao12345666333: Covered by ingress-nginx-maintainers
@Gacko
Owners: Promote myself to ingress-nginx-maintainers & `ingress-ngin…
218fae6 
…x-reviewers`.
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 4, 2024
Merged
10 tasks
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/docs labels Apr 4, 2024
@k8s-ci-robot k8s-ci-robot requested review from cpanato and puerco April 4, 2024 15:01
@k8s-ci-robot k8s-ci-robot added area/helm Issues or PRs related to helm charts needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/lua Issues or PRs related to lua code needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 4, 2024
@Gacko
Copy link
Member

Gacko commented Apr 4, 2024

/triage accepted
/retitle Owners: Promote Gacko to ingress-nginx-maintainers & ingress-nginx-reviewers.
/kind cleanup
/priority backlog

@k8s-ci-robot k8s-ci-robot changed the title [release-1.10] Owners: Promote Gacko to ingress-nginx-maintainers & ingress-nginx-reviewers. Owners: Promote Gacko to ingress-nginx-maintainers & ingress-nginx-reviewers. Apr 4, 2024
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Apr 4, 2024
@Gacko
Copy link
Member

Gacko commented Apr 4, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2024
@Gacko
Copy link
Member

Gacko commented Apr 4, 2024

/cc @strongjz @rikatz

@k8s-ci-robot k8s-ci-robot requested a review from rikatz April 4, 2024 15:03
@k8s-ci-robot k8s-ci-robot requested a review from strongjz April 4, 2024 15:03
@Gacko
Copy link
Member

Gacko commented Apr 4, 2024

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 4, 2024
cpanato
cpanato approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2024
@strongjz
Copy link
Member

strongjz commented Apr 4, 2024

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Gacko, k8s-infra-cherrypick-robot, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@strongjz strongjz merged commit 33504cf into kubernetes:release-1.10 Apr 4, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@puerco puerco Awaiting requested review from puerco

@rikatz rikatz Awaiting requested review from rikatz

@strongjz strongjz Awaiting requested review from strongjz

Assignees

@Gacko Gacko

@strongjz strongjz

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs area/helm Issues or PRs related to helm charts area/lua Issues or PRs related to lua code cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@k8s-infra-cherrypick-robot @Gacko @strongjz @k8s-ci-robot @cpanato